querier: Adds additional stats field in query api #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
requested changes
May 4, 2021
Alright, ill update the changes |
yeya24
requested changes
May 4, 2021
someshkoli
changed the title
|
@yeya24 PTAL 🙌 |
yeya24
reviewed
May 6, 2021
Also a stupid question, when and when not to update changelog ? |
kakkoyun
changed the title
|
Hi @someshkoli, please rebase on main then we can get CI fixed. |
Signed-off-by: someshkoli <[email protected]>
Signed-off-by: someshkoli <[email protected]>
Signed-off-by: someshkoli <[email protected]>
Signed-off-by: someshkoli <[email protected]>
Signed-off-by: someshkoli <[email protected]>
yeya24
reviewed
May 7, 2021
Signed-off-by: someshkoli <[email protected]>
yeya24
approved these changes
May 7, 2021
yey all greens 🎉 |
When your pr changes some known behaviors or are user-facing. IMO this change provides a new param so it is user-facing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: someshkoli [email protected]
Changes
Adds option to pass additional paramater
statsin form data for query API.Closes #4170
Verification
need to add some endpoint tests